fix(@angular/cli): respect registry in RC when running update through yarn#24209
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Nov 11, 2022
Merged
Conversation
… yarn This commit fixes an issue where when `ng update` was ran using `yarn` (`yarn ng update`) the registry was always being overridden to `https://registry.yarnpkg.com`. This is because yarn will set the `npm_config_registry` env variable to `https://registry.yarnpkg.com` even when an RC file is present with a different repository.
alan-agius4
added
the
target: patch
alan-agius4
added
the
action: review
|
@alan-agius4 I'm glad you found it! |
alan-agius4
force-pushed
the
yarn-registry-update
branch
from
948565d to
5dd1e28
Compare
alan-agius4
force-pushed
the
yarn-registry-update
branch
from
5dd1e28 to
948565d
Compare
clydin
approved these changes
Nov 11, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where when
ng updatewas ran usingyarn(yarn ng update) the registry was always being overridden tohttps://registry.yarnpkg.com.This is because yarn will set the
npm_config_registryenv variable tohttps://registry.yarnpkg.comeven when an RC file is present with a different repository.reported by @JoostK and @SanderElias over slack.